Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add include_npm_sources to npm_package #1760

Merged
merged 1 commit into from
May 28, 2024
Merged

feat: add include_npm_sources to npm_package #1760

merged 1 commit into from
May 28, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented May 28, 2024 •
edited
Loading

Since npm packages are no longer included in type in rules_js 2.0, adding the option include_npm_sources covers the use case where users want to include node_modules folders in their npm_package

Test plan

  • Covered by existing test cases
  • Added new test case

@gregmagolan gregmagolan requested a review from jbedard May 28, 2024 06:37
@gregmagolan gregmagolan mentioned this pull request May 28, 2024
Closed
21 tasks
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented May 28, 2024 •
edited
Loading

Test

1 test target passed

Targets 
//docs:update_6_test [k8-fastbuild]                 160ms

Total test execution time was 160ms. 191 tests (99.5%) were fully cached saving 52s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 467ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 693ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 9s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 923ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 248ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 520ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

21 tests (100.0%) were fully cached saving 7s.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 451ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 605ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 187ms.

Buildifier      Format

@gregmagolan gregmagolan force-pushed the add_include_npm_sources_to_npm_package branch 5 times, most recently from 5cadadc to 9cf1f6b Compare May 28, 2024 10:39
@gregmagolan gregmagolan force-pushed the add_include_npm_sources_to_npm_package branch 2 times, most recently from e953272 to e0d82db Compare May 28, 2024 17:01
@gregmagolan gregmagolan force-pushed the add_include_npm_sources_to_npm_package branch from e0d82db to f8c5307 Compare May 28, 2024 17:35
@gregmagolan gregmagolan merged commit 8533e95 into main May 28, 2024
107 checks passed
@gregmagolan gregmagolan deleted the add_include_npm_sources_to_npm_package branch May 28, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @jbedard